Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

E2E tests creating objects with gcloud #556

Closed
nachocano opened this issue Feb 14, 2020 · 7 comments
Closed

E2E tests creating objects with gcloud #556

nachocano opened this issue Feb 14, 2020 · 7 comments
Labels
area/test-and-release Test infrastructure, tests or release kind/feature-request New feature or request
Milestone

Comments

@nachocano
Copy link
Member

Problem
Our e2e tests currently create the resources using the client-go. However, many users will be inclined to use gcloud. The experience there is to create a Trigger, which in turn will create a Source and hook them together.
We've seen problems because of gcloud sending nil values as empty, unkown fields, etc.
We should have e2e tests that create things using gcloud.

Persona:
Contributor

Exit Criteria
E2E tests that use gcloud to create objects

Time Estimate (optional):
?

@nachocano nachocano added the kind/feature-request New feature or request label Feb 14, 2020
@nachocano
Copy link
Member Author

/cc @chizhg
/cc @nlopezgi keep this one in mind while you do the refactor. We will probably need a "configurable" creation step, and then reuse all the same tests...

@nachocano nachocano added the priority/2 Nice to have feature but doesn't block current release defined by release/* label Mar 2, 2020
@grantr grantr added area/test-and-release Test infrastructure, tests or release release/1 priority/1 Blocks current release defined by release/* label or blocks current milestone and removed priority/2 Nice to have feature but doesn't block current release defined by release/* labels Mar 2, 2020
@grantr grantr added this to the v0.14.0-M2 milestone Mar 9, 2020
@nachocano
Copy link
Member Author

We should also test the reply mechanism as part of these tests

@nachocano nachocano modified the milestones: v0.14.0-M2, v0.14.0-M3 Mar 18, 2020
@nachocano
Copy link
Member Author

Moving to v1beta1 seems that it might break gcloud. We need to make sure we are not.

@nlopezgi
Copy link
Contributor

nlopezgi commented Apr 2, 2020

@danyinggu will start looking at this issue

@grantr
Copy link
Contributor

grantr commented Apr 2, 2020

Great thanks @danyinggu!

/assign @danyinggu

@knative-prow-robot
Copy link
Contributor

@grantr: GitHub didn't allow me to assign the following users: danyinggu.

Note that only google members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Great thanks @danyinggu!

/assign @danyinggu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grantr grantr modified the milestones: v0.14.0-M3, v0.15.0-M2, Backlog Apr 15, 2020
@grantr grantr modified the milestones: Backlog, v0.15.0-M2 Apr 29, 2020
@ericlem ericlem removed priority/1 Blocks current release defined by release/* label or blocks current milestone release/1 labels Apr 30, 2020
@ericlem
Copy link
Contributor

ericlem commented Apr 30, 2020

We're going to test this elsewhere.

@ericlem ericlem closed this as completed Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/test-and-release Test infrastructure, tests or release kind/feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants