Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Add the cluster-name functionality to resources that need it #1055

Closed
grac3gao-zz opened this issue May 12, 2020 · 6 comments
Closed

Add the cluster-name functionality to resources that need it #1055

grac3gao-zz opened this issue May 12, 2020 · 6 comments
Labels
area/api APIs kind/feature-request New feature or request priority/2 Nice to have feature but doesn't block current release defined by release/* release/2
Milestone

Comments

@grac3gao-zz
Copy link
Contributor

Problem
Once PR #950 lands, controller can get clusterName from resource's annotation (if it is running in GKE). Using this issue to track if resources need to include cluster-name.

Persona:
Which persona is this feature for?

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

@grac3gao-zz grac3gao-zz added kind/feature-request New feature or request area/api APIs labels May 12, 2020
@grantr
Copy link
Contributor

grantr commented May 12, 2020

If we want to do any renames for R2, we should probably determine and plan that before R1.

@grantr grantr added priority/1 Blocks current release defined by release/* label or blocks current milestone release/1 labels May 12, 2020
@grantr grantr added this to the Backlog milestone May 12, 2020
@grac3gao-zz grac3gao-zz changed the title Add the cluster-name functionality to resources that needs it Add the cluster-name functionality to resources that need it May 12, 2020
@grantr
Copy link
Contributor

grantr commented May 12, 2020

Scoping the P1 exit criteria of this down to:

  • Determine if cluster name can change during the lifetime of a cluster
  • understand how cluster name affects cross-cluster correctness for all resources
  • List resources that would gain improved correctness from having cluster name available during reconcile and create issue for each

Implementation priority can be determined on per-resource issues.

@grantr
Copy link
Contributor

grantr commented Jun 15, 2020

It does not appear possible to change the cluster name in the UI or CLI.

The K8s docs state that UIDs are UUIDs (the implementation currently uses random UUIDs) so they should be unique across clusters.

Since #1207, all GCP resources owned by K8s objects include the K8s UID in their names. Thus, cluster name is not needed in the name to achieve correctness because the UID provides universal uniqueness.

Since no resources gain improved correctness from having cluster name in their resource name, I'm downgrading this to P2. When this is revisited, we should consider whether the user is better served by a GCP resource label containing the cluster name.

@grantr grantr added priority/2 Nice to have feature but doesn't block current release defined by release/* release/2 and removed priority/1 Blocks current release defined by release/* label or blocks current milestone release/1 labels Jun 15, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@grac3gao-zz
Copy link
Contributor Author

/remove-lifecycle stale

@grantr
Copy link
Contributor

grantr commented Feb 3, 2021

Closing this for now. It's no longer clear this is a good idea and cluster name is kind of hard to get.

@grantr grantr closed this as completed Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api APIs kind/feature-request New feature or request priority/2 Nice to have feature but doesn't block current release defined by release/* release/2
Projects
None yet
Development

No branches or pull requests

3 participants