-
Notifications
You must be signed in to change notification settings - Fork 74
Add the cluster-name functionality to resources that need it #1055
Comments
If we want to do any renames for R2, we should probably determine and plan that before R1. |
Scoping the P1 exit criteria of this down to:
Implementation priority can be determined on per-resource issues. |
It does not appear possible to change the cluster name in the UI or CLI. The K8s docs state that UIDs are UUIDs (the implementation currently uses random UUIDs) so they should be unique across clusters. Since #1207, all GCP resources owned by K8s objects include the K8s UID in their names. Thus, cluster name is not needed in the name to achieve correctness because the UID provides universal uniqueness. Since no resources gain improved correctness from having cluster name in their resource name, I'm downgrading this to P2. When this is revisited, we should consider whether the user is better served by a GCP resource label containing the cluster name. |
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
Closing this for now. It's no longer clear this is a good idea and cluster name is kind of hard to get. |
Problem
Once PR #950 lands, controller can get clusterName from resource's annotation (if it is running in GKE). Using this issue to track if resources need to include cluster-name.
Persona:
Which persona is this feature for?
Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.
Time Estimate (optional):
How many developer-days do you think this may take to resolve?
Additional context (optional)
Add any other context about the feature request here.
The text was updated successfully, but these errors were encountered: