no need to delete attributes

google · Jun 24, 2020 · 014802a · 014802a
1 parent 5f9afd0
commit 014802a
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/pkg/pubsub/adapter/converters/scheduler.go b/pkg/pubsub/adapter/converters/scheduler.go
@@ -37,15 +37,11 @@ func convertCloudScheduler(ctx context.Context, msg *pubsub.Message) (*cev2.Even
 	// We added this attributes so that we could identify the scheduler.
 	// We should remove them here.
 	jobName, ok := msg.Attributes[v1beta1.CloudSchedulerSourceJobName]
-	if ok {
-		delete(msg.Attributes, v1beta1.CloudSchedulerSourceJobName)
-	} else {
+	if !ok {
 		return nil, errors.New("received event did not have jobName")
 	}
 	schedulerName, ok := msg.Attributes[v1beta1.CloudSchedulerSourceName]
-	if ok {
-		delete(msg.Attributes, v1beta1.CloudSchedulerSourceName)
-	} else {
+	if !ok {
 		return nil, errors.New("received event did not have schedulerName")
 	}