Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new rememberResponsiveColumnState API #2071

Merged
merged 23 commits into from
Feb 28, 2024
Merged

new rememberResponsiveColumnState API #2071

merged 23 commits into from
Feb 28, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Feb 27, 2024 •
edited
Loading

WHAT

New Responsive SLC API, building on content type.

image

WHY

Want to get cleaner layout.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from BowerSteve February 27, 2024 17:44
@yschimke yschimke marked this pull request as ready for review February 28, 2024 11:25
@yschimke yschimke closed this Feb 28, 2024
@yschimke yschimke reopened this Feb 28, 2024
@yschimke yschimke requested a review from garanj February 28, 2024 11:36
@yschimke yschimke changed the title Testing new responsive API new rememberResponsiveColumnState API Feb 28, 2024
@yschimke yschimke closed this Feb 28, 2024
@yschimke yschimke reopened this Feb 28, 2024
BowerSteve
BowerSteve reviewed Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@BowerSteve BowerSteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CompactChip is 48dp high with 8dp padding top and bottom. So maybe the SLC top padding in the case of compact chip should be reduced by 8dp?

BowerSteve
BowerSteve approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@BowerSteve BowerSteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending update to the ItemType.Unspecified handling.

@yschimke yschimke merged commit 4fb9c92 into google:main Feb 28, 2024
1 check passed
kul3r4 pushed a commit to kul3r4/horologist-1 that referenced this pull request Feb 29, 2024
@yschimke @kul3r4
new rememberResponsiveColumnState API (google#2071)
5c913b5
@yschimke yschimke mentioned this pull request Mar 4, 2024
Merged
4 tasks
@yschimke yschimke deleted the responsive_api branch March 14, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BowerSteve BowerSteve BowerSteve approved these changes

@garanj garanj Awaiting requested review from garanj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @BowerSteve