Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Steppers with RSB built in #1749

Merged
merged 12 commits into from
Oct 9, 2023
Merged

Support for Steppers with RSB built in #1749

merged 12 commits into from
Oct 9, 2023

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Oct 9, 2023 •
edited
Loading

WHAT

Support for Steppers with RSB built in

WHY

Feedback from #1748

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke requested a review from luizgrp October 9, 2023 10:55
luizgrp
luizgrp approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

compose-material/src/main/java/com/google/android/horologist/compose/material/Stepper.kt Outdated Show resolved Hide resolved
@yschimke yschimke merged commit 9400000 into google:main Oct 9, 2023
@yschimke yschimke deleted the steppers branch November 13, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizgrp luizgrp luizgrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @luizgrp