Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that JsonTreeReader and JsonTreeWriter override all methods #2181

Conversation

Marcono1234
Copy link
Collaborator

@Marcono1234 Marcono1234 commented Aug 22, 2022

If those classes do not override one of the JsonReader or JsonWriter methods the user might encounter an AssertionError.

This was originally suggested in #2132 (comment).

Related issues:

If those classes do not override one of the JsonReader or JsonWriter methods
the user might encounter an AssertionError.
Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful, thanks! Just one small suggestion to simplify slightly.

gson/src/test/java/com/google/gson/common/MoreAsserts.java Outdated Show resolved Hide resolved
@eamonnmcmanus eamonnmcmanus merged commit 325f37c into google:master Aug 23, 2022
@Marcono1234 Marcono1234 deleted the marcono1234/JsonTreeReader-JsonTreeWriter-overrides-test branch August 24, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants