-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve JsonReader.skipValue()
#2062
Merged
eamonnmcmanus
merged 8 commits into
google:master
from
Marcono1234:marcono1234/JsonReader-skipValue-improvements
Oct 10, 2022
Merged
Improve JsonReader.skipValue()
#2062
eamonnmcmanus
merged 8 commits into
google:master
from
Marcono1234:marcono1234/JsonReader-skipValue-improvements
Oct 10, 2022
Commits on Jan 23, 2022
-
Fix JsonReader.skipValue() not behaving properly at end of document
JsonReader implementation erroneously reset `peeked` to PEEKED_NONE; JsonTreeReader threw ArrayIndexOutOfBoundsException.
Configuration menu - View commit details
-
Copy full SHA for d3c584b - Browse repository at this point
Copy the full SHA d3c584bView commit details -
Fix JsonReader.skipValue() not behaving properly at end of array and …
…object For JsonReader this caused an IllegalStateException (in the past it caused JsonReader to get stuck in an infinite loop); for JsonTreeReader it only popped the empty iterator but not the JsonArray or JsonObject, which caused peek() to again report END_ARRAY or END_OBJECT.
Configuration menu - View commit details
-
Copy full SHA for 08e614d - Browse repository at this point
Copy the full SHA 08e614dView commit details -
Only have JsonReader.skipValue() overwrite path name when name was sk…
…ipped This improves the JSON path when the value for a property was skipped and before the subsequent property (or the end of the object) getPath() is called.
Configuration menu - View commit details
-
Copy full SHA for 98f6246 - Browse repository at this point
Copy the full SHA 98f6246View commit details
Commits on Jan 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1d43ecf - Browse repository at this point
Copy the full SHA 1d43ecfView commit details
Commits on Sep 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 242a1aa - Browse repository at this point
Copy the full SHA 242a1aaView commit details
Commits on Sep 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 873aa6a - Browse repository at this point
Copy the full SHA 873aa6aView commit details
Commits on Sep 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9291d3c - Browse repository at this point
Copy the full SHA 9291d3cView commit details
Commits on Oct 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b7b5c3e - Browse repository at this point
Copy the full SHA b7b5c3eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.