Specify timezone for GregorianCalender in testDateFormatString() #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way I think the reason this "bug" was introduced is that the test passes if you are western to UTC (which means that your date is somewhere between 2018-08-25 00:00 and 2018-08-25 12:00, but since I'm living in Germany, it's 2018-08-24 22:00 (and in general 24th between 12:00 and 00:00)). So TL;DR currently this test passes only if your computer has a timezone between UTC-12 and UTC |
The date is formatted using format(Date) which uses UTC-timezone as no other timezone is specified GregorianCalender instead uses the system-default timezone, which makes this test not pass in all timezones Therefore the timezone of the calender should be specified before it's used to create a Date-instance using (by default) UTC-timezone
|
Why this PR is not still merged? |
|
@asolntsev seems like gson is no longer actively maintained: #1821 |
|
This was fixed by #1687; thanks nonetheless for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date is formatted using format(Date) which uses UTC-timezone as no other timezone is specified
GregorianCalender instead uses the system-default timezone, which makes this test not pass in all timezones
Therefore the timezone of the calender should be specified before it's used to create a Date-instance using (by default) UTC-timezone