Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using impersonate service account with gcloud cli #456

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions googleapis_auth/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
- Added an optional `listenPort` parameter to `clientViaUserConsent`
and `obtainAccessCredentialsViaUserConsent`.

#### `auth_io.dart`

- Handle the `source_credentials` from the credentials file to support
usage of impersonating service account with gcloud cli.

## 1.3.1

- Include `plugin_name` during browser authorization.
Expand Down
15 changes: 11 additions & 4 deletions googleapis_auth/lib/src/adc_utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,16 @@ Future<AutoRefreshingAuthClient> fromApplicationsCredentialsFile(
);
}

if (credentials is Map && credentials['type'] == 'authorized_user') {
if (credentials is Map &&
(credentials['type'] == 'authorized_user' ||
credentials['type'] == 'impersonated_service_account')) {
final credentialsValue = credentials['type'] == 'authorized_user'
? credentials
: credentials['source_credentials'] as Map;

final clientId = ClientId(
credentials['client_id'] as String,
credentials['client_secret'] as String?,
credentialsValue['client_id'] as String,
credentialsValue['client_secret'] as String?,
);
return AutoRefreshingClient(
baseClient,
Expand All @@ -45,14 +51,15 @@ Future<AutoRefreshingAuthClient> fromApplicationsCredentialsFile(
AccessCredentials(
// Hack: Create empty credentials that have expired.
AccessToken('Bearer', '', DateTime(0).toUtc()),
credentials['refresh_token'] as String?,
credentialsValue['refresh_token'] as String?,
scopes,
),
baseClient,
),
quotaProject: credentials['quota_project_id'] as String?,
);
}

return await clientViaServiceAccount(
ServiceAccountCredentials.fromJson(credentials),
scopes,
Expand Down
58 changes: 58 additions & 0 deletions googleapis_auth/test/adc_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,64 @@ void main() {
}
});

test('fromApplicationsCredentialsFile w. source_credentials', () async {
final tmp = await Directory.systemTemp.createTemp('googleapis_auth-test');
try {
final credsFile = File.fromUri(tmp.uri.resolve('creds.json'));
await credsFile.writeAsString(json.encode({
'service_account_impersonation_url': 'url',
'source_credentials': {
'client_id': 'id',
'client_secret': 'secret',
'refresh_token': 'refresh',
'type': 'authorized_user'
},
'type': 'impersonated_service_account',
}));
final c = await fromApplicationsCredentialsFile(
credsFile,
'test-credentials-file',
[],
mockClient((Request request) async {
final url = request.url;
if (url == googleOauth2TokenEndpoint) {
expect(request.method, equals('POST'));
expect(
request.body,
equals('client_id=id&'
'client_secret=secret&'
'refresh_token=refresh&'
'grant_type=refresh_token'));
final body = jsonEncode({
'token_type': 'Bearer',
'access_token': 'atoken',
'expires_in': 3600,
});
return Response(body, 200, headers: jsonContentType);
}
if (url.toString() ==
'https://storage.googleapis.com/b/bucket/o/obj') {
expect(request.method, equals('GET'));
expect(request.headers['Authorization'], equals('Bearer atoken'));
expect(request.headers['X-Goog-User-Project'], isNull);
return Response('hello world', 200);
}
return Response('bad', 404);
}),
);
expect(c.credentials.accessToken.data, equals('atoken'));

final r =
await c.get(Uri.https('storage.googleapis.com', '/b/bucket/o/obj'));
expect(r.statusCode, equals(200));
expect(r.body, equals('hello world'));

c.close();
} finally {
await tmp.delete(recursive: true);
}
});

test('fromApplicationsCredentialsFile w. quota_project_id', () async {
final tmp = await Directory.systemTemp.createTemp('googleapis_auth-test');
try {
Expand Down
Loading