README: Update version references from 1.6 to 1.7 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I50dc9e8c4dbe8f44abcff169baabd13a4f861166 Signed-off-by: David Pursehouse <dpursehouse@collab.net>
dpursehouse
commented
Apr 15, 2019
There was a problem hiding this comment.
@cushon any chance to get this merged? it'll need a new version of the Eclipse plugin to be published unless that update in the README is backed out of this commit.
| @@ -54,7 +54,7 @@ and import it into File→Settings→Editor→Code Style. | |||
| ### Eclipse | |||
|
|
|||
| A | |||
| [google-java-format Eclipse plugin](https://github.com/google/google-java-format/releases/download/google-java-format-1.6/google-java-format-eclipse-plugin_1.6.0.jar) | |||
| [google-java-format Eclipse plugin](https://github.com/google/google-java-format/releases/download/google-java-format-1.7/google-java-format-eclipse-plugin_1.7.0.jar) | |||
There was a problem hiding this comment.
Version 1.7 of the plugin wasn't published yet. See #331 .
Closed
ronshapiro
pushed a commit
that referenced
this pull request
Apr 16, 2019
Fixes #343,#352,#350 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=243715974
Merged
ronshapiro
pushed a commit
that referenced
this pull request
Apr 16, 2019
Fixes #343,#352,#350 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=243715974
|
I took one of the other 3 PRs that updated the README to 1.7. I didn't take the update to the Eclipse plugin because that needs followup on our part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.