Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change org id to int64 in OrganizationsListOptions #899

Merged
merged 2 commits into from
Apr 24, 2018

Conversation

qinfchen
Copy link
Contributor

Change org ID in OrganizationsListOptions to be consistent with the org id type

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@qinfchen
Copy link
Contributor Author

I signed it!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this, @qinfchen!
LGTM.

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 23, 2018

@googlebot - please rescan.

Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both RepositoryListAllOptions and UserListOptions already use int64 for their similar Since field. Looks like we missed this one. Thanks for catching this.

LGTM.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Apr 24, 2018
@dmitshur dmitshur merged commit ab468aa into google:master Apr 24, 2018
@dmitshur
Copy link
Member

Thanks @qinfchen!

@qinfchen qinfchen deleted the qchen/orgId branch April 24, 2018 21:59
nbareil pushed a commit to nbareil/go-github that referenced this pull request May 1, 2018
Field Since in OrganizationsListOptions refers to an organization ID,
so its type needs to be int64 to per prior decision in google#597.
This is already the case in other similar structs such as
RepositoryListAllOptions and UserListOptions.

This is a breaking API change that is a part of resolving issue google#597.
It should've been applied earlier, but we missed it (likely because
the field doesn't have "ID" in its name, so it's harder to spot).

Updates google#597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants