Skip to content

Conversation

zyfy29
Copy link
Contributor

@zyfy29 zyfy29 commented Sep 24, 2025

BREAKING CHANGE: Permissions-related methods are renamed from Edit* to Update*.

Rename the methods EditXXX to UpdateXXX for the permissions related apis

accomplish #3679 (comment)

@gmlewis gmlewis changed the title refactor: replace Edit with Update in permissions method names refactor!: Replace Edit with Update in permissions method names Sep 24, 2025
@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Sep 24, 2025
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.11%. Comparing base (1b53270) to head (6c88d60).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
example/actionpermissions/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3731   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files         187      187           
  Lines       16686    16686           
=======================================
  Hits        15204    15204           
  Misses       1295     1295           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zyfy29!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear

@zyfy29
Copy link
Contributor Author

zyfy29 commented Sep 24, 2025

@gmlewis Thanks, it's nice to see you back!

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 25, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 25, 2025

Thank you, @stevehipwell!
Merging.

@gmlewis gmlewis merged commit 215d1ca into google:master Sep 25, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants