Skip to content

fix!: Change ListCheckSuiteOptions.AppID from int to int64 #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

fix!: Change ListCheckSuiteOptions.AppID from int to int64 #3633

merged 1 commit into from
Jul 22, 2025

Conversation

stevehipwell
Copy link
Contributor

@stevehipwell stevehipwell commented Jul 22, 2025 •
edited by gmlewis
Loading

BREAKING CHANGE: Change ListCheckSuiteOptions.AppID from int to int64

Fixes: #3631

@stevehipwell
fix: correct list check suite options app id
f498ece 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@gmlewis gmlewis changed the title fix: correct list check suite options app id fix!: Change ListCheckSuiteOptions.AppID from int to int64 Jul 22, 2025
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jul 22, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (99ffabe) to head (f498ece).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3633   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files         184      184           
  Lines       16174    16174           
=======================================
  Hits        14773    14773           
  Misses       1227     1227           
  Partials      174      174

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis
gmlewis approved these changes Jul 22, 2025
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell!
LGTM.
Merging.

@gmlewis gmlewis merged commit 6540c41 into google:master Jul 22, 2025
7 checks passed
@stevehipwell stevehipwell deleted the fix-check-suite-app-id branch July 22, 2025 12:09
@gmlewis gmlewis mentioned this pull request Jul 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The AppID field of ListCheckSuiteOptions is an int
2 participants
@stevehipwell @gmlewis