Skip to content

Add OldLogin field to AuditEntryData #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Add OldLogin field to AuditEntryData #2850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efde92c
Add `OldLogin` field to `AuditEntryData`
lmartinking Jul 28, 2023
bcb0e54
update accessors
lmartinking Jul 28, 2023
61560e8
update tests
lmartinking Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions github/github-accessors_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion github/orgs_audit_log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ type AuditEntry struct {

// AuditEntryData represents additional information stuffed into a `data` field.
type AuditEntryData struct {
OldName *string `json:"old_name,omitempty"` // The previous name of the repository, for a name change
OldName *string `json:"old_name,omitempty"` // The previous name of the repository, for a name change
OldLogin *string `json:"old_login,omitempty"` // The previous name of the organization, for a name change
}

// GetAuditLog gets the audit-log entries for an organization.
Expand Down
6 changes: 4 additions & 2 deletions github/orgs_audit_log_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,8 @@ func TestAuditEntry_Marshal(t *testing.T) {
WorkflowID: Int64(1),
WorkflowRunID: Int64(1),
Data: &AuditEntryData{
OldName: String("on"),
OldName: String("on"),
OldLogin: String("ol"),
},
}

Expand Down Expand Up @@ -396,7 +397,8 @@ func TestAuditEntry_Marshal(t *testing.T) {
"workflow_id": 1,
"workflow_run_id": 1,
"data": {
"old_name": "on"
"old_name": "on",
"old_login": "ol"
}
}`

Expand Down