Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for repo setting use_squash_pr_title_as_default #2390

Merged
merged 2 commits into from
Jun 19, 2022

Conversation

garrettheel
Copy link
Contributor

@google-cla
Copy link

google-cla bot commented Jun 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@garrettheel garrettheel changed the title Add support for repository setting Add support for repository setting use_squash_pr_title_as_default Jun 19, 2022
@garrettheel garrettheel changed the title Add support for repository setting use_squash_pr_title_as_default Add support for repo setting use_squash_pr_title_as_default Jun 19, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @garrettheel !
Just a few minor tweaks, please, before we merge.

github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
github/repos.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #2390 (1dc51d6) into master (697804f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2390   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         119      119           
  Lines       10545    10546    +1     
=======================================
+ Hits        10341    10342    +1     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/repos.go 98.66% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697804f...1dc51d6. Read the comment docs.

@garrettheel
Copy link
Contributor Author

@gmlewis thanks for reviewing, addressed your comments!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @garrettheel !
LGTM.
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants