-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github/repos: remove omitempty option in BranchRestrictionsRequest #1571
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1571 +/- ##
=======================================
Coverage 67.95% 67.95%
=======================================
Files 96 96
Lines 8762 8762
=======================================
Hits 5954 5954
Misses 1898 1898
Partials 910 910
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @anGie44 !
LGTM, and unless you know of a solution using curl
that we could reverse-engineer, then I don't have any other suggestions than to just go ahead and merge this PR.
Awaiting second LGTM before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well
Thank you, @andrew-waters! |
thank you @gmlewis and @andrew-waters! would love to get this in the next release to help the Terraform Provider Github project benefit from the new features already in v32 |
Sorry for the delay... hopefully I can get to this tomorrow. |
@anGie44 - this is now available in Release |
Not a problem, @gmlewis! thanks so much for your help and review 😃 |
Closes #1546
Notes:
BranchRestrictionsRequest
as it does not behave as expected such that restrictions configured for individual repositories still result in an error if users/teams fields are not set e.g.or if set to
nil
or[]string{}
e.g.