Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message for the test of GetWorkflowRunByID #1529

Merged
merged 1 commit into from
May 18, 2020
Merged

Fix error message for the test of GetWorkflowRunByID #1529

merged 1 commit into from
May 18, 2020

Conversation

joshuabezaleel
Copy link
Contributor

Fixes #1528

Small PR to change the error message of the test of GetWorfklowRunByID that uses ListWorkFlowRunsByFileName instead.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 18, 2020
@codecov
Copy link

codecov bot commented May 18, 2020 •
edited
Loading

Codecov Report

Merging #1529 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1529   +/-   ##
=======================================
  Coverage   68.03%   68.03%           
=======================================
  Files          94       94           
  Lines        8528     8528           
=======================================
  Hits         5802     5802           
  Misses       1844     1844           
  Partials      882      882

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c5021...11df983. Read the comment docs.

wesleimp
wesleimp approved these changes May 18, 2020
View reviewed changes
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@wesleimp wesleimp requested a review from gmlewis May 18, 2020 18:33
gmlewis
gmlewis approved these changes May 18, 2020
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joshuabezaleel and @wesleimp!
LGTM.
Merging.

@gmlewis gmlewis merged commit 4392860 into google:master May 18, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@joshuabezaleel
Fix error message for the test of GetWorkflowRunByID (google#1529)
4b96619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@wesleimp wesleimp wesleimp approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong error message on the test for GetWorkflowRunByID
4 participants
@joshuabezaleel @gmlewis @wesleimp @googlebot