FIX: allow empty commitMessage for merging pulls #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is specifically motivated by the desire to replicate
the same behavior as observed when merging PR's manually using
the "Squash and Merge" option. In that case, a commit message
including the title and commit message of all the commits in the
PR are included, and the squashed commit includes all of that
context.
I have tested that its possible to merge a Pull Request with
an empty commit message and verified that the api call replicates
the desired behavior:
```
curl -XPUT \
-H "Accept: application/vnd.github.v3+json" \
-H "Authorization: token $GITHUB_API_TOKEN" \
-d '{"merge_method":"squash"}' \
https://api.github.com/repos/pratikmallya/test/pulls/4/merge
{
"sha": "08d173ee449e4ea505d8366b9fa416d6d3923f23",
"merged": true,
"message": "Pull Request successfully merged"
}
```
The merge commit: pratikmallya/test@08d173e
is exactly the behavior that I am seeking.
googlebot
added
the
cla: yes
gmlewis
approved these changes
Mar 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is specifically motivated by the desire to replicate
the same behavior as observed when merging PR's manually using
the "Squash and Merge" option. In that case, a commit message
including the title and commit message of all the commits in the
PR are included, and the squashed commit includes all of that
context.
I have tested that its possible to merge a Pull Request with
an empty commit message and verified that the api call replicates
the desired behavior:
The merge commit: pratikmallya/test@08d173e
is exactly the behavior that I am seeking.
Fixes: #1448