Skip to content

Push event's Pusher is not the correct type #2998

@caseyduquettesc

Description

@caseyduquettesc

The Push event includes a Pusher, which only has four fields:

  • date
  • email
  • name
  • username

The PushEvent type includes a Pusher, but the type is a full User object, which not only will have most fields unfilled, but more importantly, the username from the webhook is lost because a typical User includes a login, not username.

https://docs.github.com/en/webhooks/webhook-events-and-payloads#push

These should probably be distinct objects, much like Repository and PushEventRepository are distinct.

I'll send a PR for this in a bit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions