-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return better error when pulling schema 1 #344
Conversation
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 50.7% 50.67% -0.03%
==========================================
Files 74 74
Lines 3394 3396 +2
==========================================
Hits 1721 1721
- Misses 1412 1413 +1
- Partials 261 262 +1
Continue to review full report at Codecov.
|
Possibly, this is too much text:
|
Closed for #377 instead. |
@jonjohnsonjr Should this PR be resurrected unless and until #377 is implemented? |
Yeah I think I have a better way of handling this than we do in this PR by actually checking the returned mediaType instead of trying to parse it. I'll send a simpler one. |
@jonjohnsonjr Thanks. Raised #411 so this doesn't get forgotten. |
See GoogleContainerTools/kaniko#509