Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutate doesn't update config size #192

Closed
jonjohnsonjr opened this issue Jun 2, 2018 · 0 comments
Closed

Mutate doesn't update config size #192

jonjohnsonjr opened this issue Jun 2, 2018 · 0 comments
Assignees
@mattmoor

Comments

@jonjohnsonjr
Copy link
Collaborator

jonjohnsonjr commented Jun 2, 2018 •
edited
Loading

If a config file mutation changes the size of a config file, the manifest isn't getting updated with the new size. This causes containerd to blow up when it sees a size mismatch.

Related: #88
@mattmoor mattmoor self-assigned this Jun 2, 2018
mattmoor added a commit to mattmoor/go-containerregistry that referenced this issue Jun 2, 2018
@mattmoor
Recompute the size in the same places that we recompute the digest.
536699a 
Fixes: google#192
@mattmoor mattmoor mentioned this issue Jun 2, 2018
Merged
mattmoor added a commit to mattmoor/go-containerregistry that referenced this issue Jun 2, 2018
@mattmoor
Recompute the size in the same places that we recompute the digest.
465298f 
Fixes: google#192
mattmoor added a commit that referenced this issue Jun 2, 2018
@mattmoor
Recompute the size in the same places that we recompute the digest. (#…
fa3ceb6 
…193)

Fixes: #192
This was referenced Aug 9, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattmoor mattmoor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattmoor @jonjohnsonjr