Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-virtualize interfaces for specialized diffing #254

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Conversation

dsnet
Copy link
Collaborator

@dsnet dsnet commented Mar 3, 2021

Specialized diffing strings and slices should occur for
interface types where both values have the same concrete type.
This is especially relevant for protocmp.Transform,
which transforms every proto.Message as a map[string]interface{}.

Specialized diffing strings and slices should occur for
interface types where both values have the same concrete type.
This is especially relevant for protocmp.Transform,
which transforms every proto.Message as a map[string]interface{}.
@dsnet dsnet requested a review from neild March 3, 2021 04:23
@dsnet dsnet merged commit dc6435e into master Mar 3, 2021
@dsnet dsnet deleted the diff-string branch March 3, 2021 17:41
This was referenced Mar 6, 2021
This was referenced Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants