Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows clang CI for CC toolchain resolution #877

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

jsharpe
Copy link
Contributor

@jsharpe jsharpe commented Nov 29, 2022

Select the correct toolchain and platform for
building with clang on windows with CC toolchain
resolution active.

Attempting to fix #876

Select the correct toolchain and platform for
building with clang on windows with CC toolchain
resolution active.
@jsharpe jsharpe marked this pull request as ready for review November 29, 2022 23:26
@jsharpe
Copy link
Contributor Author

jsharpe commented Nov 29, 2022

@comius @meteorcloudy I think this should fix the incompatible_enable_cc_toolchain_resolution build for this package.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #877 (0dfb5eb) into master (05fbc65) will increase coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
+ Coverage   73.29%   73.62%   +0.32%     
==========================================
  Files          17       17              
  Lines        3292     3298       +6     
==========================================
+ Hits         2413     2428      +15     
+ Misses        879      870       -9     
Impacted Files Coverage Δ
src/logging.cc 75.05% <0.00%> (+0.14%) ⬆️
src/symbolize.cc 66.76% <0.00%> (+2.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@drigz
Copy link
Member

drigz commented Nov 30, 2022

Thanks, buildkite logs look good! Do you know if --incompatible_enable_cc_toolchain_resolution is already the default at head, or should we run a build explicitly setting --incompatible_enable_cc_toolchain_resolution to check this?

@comius
Copy link
Contributor

comius commented Nov 30, 2022

Do you know if --incompatible_enable_cc_toolchain_resolution is already the default at head, or should we run a build explicitly setting --incompatible_enable_cc_toolchain_resolution to check this?

It's false at head, you need to set it manually.

@drigz
Copy link
Member

drigz commented Nov 30, 2022

Many thanks, Ivo. I explicitly enabled it for a test build and it seems happy: https://buildkite.com/bazel/google-logging/builds/3010#0184c7ce-6aa4-4803-8e30-50ab4834352f

@drigz drigz merged commit c18db39 into google:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag --incompatible_enable_cc_toolchain_resolution will break Google Logging in Bazel 7.0
4 participants