Vulkan MEC: Finish secondary command buffers prior to primary ones #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
approved these changes
May 4, 2017
According to spec, when primary command buffers call vkCmdExecuteCommands, all the related secondary command buffers must be in pending/executable state, cannot be in recording state.
Qining
force-pushed
the
end-all-secondary-cmd-buf-first
branch
from
0a3ac0d to
25687de
Compare
RenfengLiu
pushed a commit
to RenfengLiu/gapid
that referenced
this pull request
Apr 23, 2020
Add support for iOS and macOS via MoltenVK
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
This option is needed to make the "Max Memory" field of benchmark stats be non-zero. Bug: b/159127803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to spec, when primary command buffers call
vkCmdExecuteCommands, all the related secondary command buffers must be
in pending/executable state, cannot be in recording state.