Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to fix build on Xcode 10 #2523

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Minor changes to fix build on Xcode 10 #2523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gapii/cc/spy_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class PackEncoder;
class SpyBase {
public:
SpyBase();
virtual ~SpyBase() {}

void init(CallObserver* observer);

Expand Down
2 changes: 1 addition & 1 deletion gapir/cc/context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class Context : private Renderer::Listener {
ResourceLoader* resource_loader,
MemoryManager* memory_manager);

~Context();
virtual ~Context();

void prefetch(ResourceCache* cache) const;

Expand Down
1 change: 1 addition & 0 deletions gapir/cc/renderer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class Renderer {
public:
virtual void onDebugMessage(uint32_t severity, uint8_t api_index,
const char* msg) = 0;
virtual ~Listener() {}
};

inline Renderer();
Expand Down