Vulkan: Correctly handle 3D images with 2D views #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe change the name |
AWoloszyn
approved these changes
Dec 18, 2018
bjoeris
force-pushed
the
3d-image-2d-view-2
branch
2 times, most recently
from
b4c2ced to
6ae346d
Compare
Qining
approved these changes
Dec 18, 2018
The spec allows 2D `VkImageView`s of 3D `VkImage`s. The array layers of the 2D view correspond to depth in the 3D image. For example, the valid usage for VkImageViewCreateInfo specifies: > If subresourceRange::layerCount is not VK_REMAINING_ARRAY_LAYERS, image is a > 3D image created with VK_IMAGE_CREATE_2D_ARRAY_COMPATIBLE_BIT set, and > viewType is VK_IMAGE_VIEW_TYPE_2D or VK_IMAGE_VIEW_TYPE_2D_ARRAY, > subresourceRange::layerCount must be non-zero and > subresourceRange::baseArrayLayer + subresourceRange::layerCount must be less > than or equal to the extent.depth specified in VkImageCreateInfo when image > was created
bjoeris
force-pushed
the
3d-image-2d-view-2
branch
from
6ae346d to
01bf8df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec allows 2D
VkImageViews of 3DVkImages. The array layers of the 2Dview correspond to depth in the 3D image. For example, the valid usage for
VkImageViewCreateInfo specifies: