Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some methods on Sequential container #4565

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Ruhaan838
Copy link

@Ruhaan838 Ruhaan838 commented Feb 22, 2025

What does this PR do?

This PR adds new methods in the Sequential container that exists in flax/nnx/helpers.py methods like

  • __add__ -> add two Sequential container. similar __iadd__
  • __mul__ -> multiply the current Sequential container with the number and return a new container. similar __rmul__, __imul__
  • __iter__ , __getitem__, __setitem__, __delitem__, __len__ same and useful.
  • other list methods like append, extend, pop, and insert.

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

Copy link

google-cla bot commented Feb 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Ruhaan838
Copy link
Author

@cgarciae can you review this PR and merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant