[.NET] Fix VerifyUnion using wrong offset for typeId #8360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offset was overwritten to point to the data before the typeId was set.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Oh well, too bad having a Google account is a requirement for contributing. Seems like this change won't make its way into the repo then I guess. |
0x4261756D
added a commit
to 0x4261756D/CardGame
that referenced
this pull request
Jul 16, 2024
This fails when trying to start a room and artwork fetching was disabled because packets got too big (not quite sure why exactly). Negative things about FlatBuffers: * Verification is bugged in the upstream C# library, hence the submodule. * I opened a [PR](google/flatbuffers#8360) but since you need a Google account to have any chance of getting merged it seems like there is no hope for getting it in. * Enum variants being untyped is **HIGHLY** irritating, I have already encountered more than one case of using `Packet` instead of `PacketT` and only catching it because the verifier on the other side rejects it. * The verifier does not tell you what failed. As brittle as this whole library is just spitting out a "no" is entirely unhelpful. * Many parts of the C# library seem weird. It is hard to compare them to their counterparts in other languages since they differ quite a lot but on several occasions it was unclear to me whether *I* did something wrong or the library is just buggy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset was overwritten to point to the data before the typeId was set.