-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/reexport python type infos #8356
base: master
Are you sure you want to change the base?
Conversation
Thanks for the fixes, @fliiiix! Can you provide more details on the re-export issue? Why does the default behaviour – exporting everything that does not start with a As for the dot in the filename, it looks like a bug. It should be an |
re-export issue
I will look more into that, i'm not a 100% sure yet how it works.
underscore issue
Cool so i hopefully find time this week to provide a fix for that grpc file location
we have a portal file something like this:
Which generates a folder And before some change the |
@anton-bobukh I marked this MR as Draft and opened #8359 for point 2 and 3. I need some more time to analyze the re-export problem.
I'm not sure yet if the best approach is to remove the import or use this |
8b41104
to
7c06c55
Compare
7c06c55
to
7d6aa5e
Compare
Importing the Base type for `--gen-object-api` in `.pyi` files eg. `from namespace.Type import Type` can lead to re-export issues depeding on how the generated code is embeded. To prevent this the import is removed since the data Type is always defined just on top.
7d6aa5e
to
2a1790e
Compare
I tried to use the new
.pyi
files and stumbled over the re-export problem.This change adds the classes in
.pyi
to__all__
to allow re-export.Regenerated the grcp for python correctly i think that was missed with
3b27f53 and feels to me like an unwanted regression
in 1. generating the file in a different location and 2. generate it by default with a
.
in the file name which makes it nearly impossible to import with Python@anton-bobukh 🔝 Did i misunderstand something?
And my
clang-format
didn't agree with some things.@dbaileychess Is there a specific version which should be used?