Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Add Automatic-Module-Name to Manifest file #8350

Conversation

danepitkin
Copy link

@danepitkin danepitkin commented Jul 2, 2024

This change explicitly defines the module name for flatbuffers for Java 9+. Without this configuration, the module name is auto-generated based on the filename flatbuffers-java.

This is the current warning during compile time for downstream projects:

Warning:  **********************************************************************************************************************************************************************
Warning:  * Required filename-based automodules detected: [flatbuffers-java-24.3.25.jar]. Please don't publish this project to a public artifact repository! *
Warning:  **********************************************************************************************************************************************************************

Fixes: #8348

Copy link

google-cla bot commented Jul 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@danepitkin
Copy link
Author

This Flatbuffers PR will benefit the Java community. It prevents Java module dependency problems when multiple downstream libraries want to use Flatbuffers. Apache Arrow is one such project that utilizes Java Flatbuffers and supports JPMS. I found a blog post that provides a detailed description of the problem: https://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html cc @dbaileychess

@danepitkin
Copy link
Author

Closing in favor of #8367

@danepitkin danepitkin closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java] Add Automatic-Module-Name to Manifest file
1 participant