Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Make code compile with -Wfloat-equal #8221

Merged
merged 2 commits into from
May 29, 2024

Commits on Jan 21, 2024

  1. [C++] Make code compile with -Wfloat-equal

    This will allow the code to be compiled with `-Wfloat-equal`
    as this would result in the folowing warning/error:
    vendor/flatbuffers/include/flatbuffers/base.h:465:69:
      error: comparing floating point with == or != is unsafe [-Werror,-Wfloat-equal]
    template<typename T> inline bool IsTheSameAs(T e, T def) { return e == def; }
    
    But the way it is used in flatbuffers it is ok to compare floating
    points with ==.
    fliiiix committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    a9f2cd9 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    c85da4a View commit details
    Browse the repository at this point in the history