Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatbuffers Version 23.1.20 #7794

Merged
merged 3 commits into from
Jan 21, 2023
Merged

Conversation

le-michael
Copy link
Collaborator

No description provided.

@le-michael
Copy link
Collaborator Author

@dbaileychess mac builds seem to be broken on this PR and others.

@dbaileychess
Copy link
Collaborator

Hmm, looks like:

/Users/runner/work/flatbuffers/flatbuffers/src/binary_annotator.h:55:74: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int' [-Werror,-Wshorten-64-to-32]
  stream << std::hex << std::uppercase << std::setfill('0') << std::setw(width)
                                                               ~~~       ^~~~~
/Users/runner/work/flatbuffers/flatbuffers/src/binary_annotator.h:62:10: note: in instantiation of function template specialization 'flatbuffers::ToHex<int>' requested here
  return ToHex(static_cast<int>(i), 2);

Could you attempt a fix and just put it in this PR?

@le-michael
Copy link
Collaborator Author

@dbaileychess yup fixed

@dbaileychess dbaileychess enabled auto-merge (squash) January 21, 2023 20:03
@dbaileychess dbaileychess merged commit 1703662 into google:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants