Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go.mod to resolve ambiguous import issue #7783

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

le-michael
Copy link
Collaborator

@le-michael le-michael commented Jan 12, 2023

Fixes #7780

Introducing a go.mod file into the go sub-directory resulted in versioning issues for many clients. We should revert the change and figure out a better/safer way to introduce a go.mod file.

After removing the go.mod file we'll have to wait till the next release before the issue is resolved.

@dbaileychess dbaileychess merged commit 8179920 into google:master Jan 19, 2023
@ceejatec
Copy link

Are you now done making go.mod changes? This change broke our builds yet again.

module github.com/google/flatbuffers@latest found (v23.1.4+incompatible), but does not contain package github.com/google/flatbuffers/go

@le-michael
Copy link
Collaborator Author

Yes this will be the last change. Once a new release is cut the issue should be resolved and you can go back to using github.com/google/flatbuffers as the module name. Sorry about the inconvenience.

@le-michael
Copy link
Collaborator Author

@ceejatec this should be fixed now let me know if you have still have any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Go] Introducing go.mod file causes versioning issue
3 participants