Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LongEnum definitions #7596

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Conversation

battre
Copy link
Member

@battre battre commented Oct 20, 2022

The MyGame/Example/LongEnum.java class did not compile because Java expects an "L" suffix for literals of type long.

This CL fixes the code generation to include such a suffix.

This fixes issue #7593

@github-actions github-actions bot added c++ codegen Involving generating code from schema java labels Oct 20, 2022
The MyGame/Example/LongEnum.java class did not compile because
Java expects an "L" suffix for literals of type long.

This CL fixes the code generation to include such a suffix.
@dbaileychess dbaileychess merged commit f7b7344 into google:master Oct 21, 2022
@dbaileychess
Copy link
Collaborator

Great, easy enough!

@battre battre deleted the bug-7593-longenum branch October 21, 2022 06:24
bulentv pushed a commit to zdrealityhub/flatbuffers that referenced this pull request Oct 21, 2022
The MyGame/Example/LongEnum.java class did not compile because
Java expects an "L" suffix for literals of type long.

This CL fixes the code generation to include such a suffix.

Co-authored-by: Dominic Battre <battre@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants