[vector] Allow to iterate with mutables #7586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaileychess
approved these changes
Oct 21, 2022
|
Thanks! Sorry for the delay. |
bulentv
pushed a commit
to zdrealityhub/flatbuffers
that referenced
this pull request
Oct 21, 2022
Co-authored-by: ArnaudD-FR <arnaud.desmier@gmail.com> Co-authored-by: Derek Bailey <derekbailey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using mutable buffers it is currently impossible to deference iterators without having a compiler error due to struct IndirectHelper::Read returning return_type instead of mutable_return_type:
struct VectorIterator {
...
// compiler error: failed to convert const value (IndirectHelper::return_type)
// to non const value (IndirectHelper::mutable_return_type, aka IT)
IT operator*() const { return IndirectHelper::Read(data_, 0); }
IT operator->() const { return IndirectHelper::Read(data_, 0); }
...
};
The main idea behind this PR is to have an VectorIterator using uint8_t * and VectorConstIterator using const uint8_t * as data to use the correct overload of IndirectHelper::Read
So VectorIterator has a new template parameter to switch from const_iterator to iterator. Side effect, as array was also using VectorIterator it is now using VectorConstIterator.
This will fix issue #4674
Duplicate of PR #7294