Add support for metadata attributes for enum values (#7567) #7568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c++
codegen
|
High level LGTM but looks like there's some CI checks to fix |
|
Yes, there was a problem with path lookup in my test. It should be fixed now. |
|
And there was another problem with Windows paths, but it is all resolved now. |
CasperN
approved these changes
Oct 7, 2022
|
Thanks! |
bulentv
pushed a commit
to zdrealityhub/flatbuffers
that referenced
this pull request
Oct 18, 2022
…ogle#7568) * Add support for metadata attributes for enum values (google#7567) * Fix path lookup in flatc test * Try a fix for Windows paths * Convert path to string to fix Windows error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for metadata attributes for enum values as described in feature request #7567.
I based it on the existing parser code for metadata attributes on other definitions and it appears to work as expected, after re-generating the schema code.
I also added a unit test in one of the Python tests for flatc to make sure that the generated schema contains what is expected.