Remove @ExperimentalUnsignedTypes annotation from kotlin code generator. #7092
Conversation
github-actions
bot
added
c++
codegen
|
@paulovap Do you want to take a look? |
| @@ -259,7 +259,6 @@ class KotlinGenerator : public BaseGenerator { | |||
| GenerateComment(enum_def.doc_comment, writer, &comment_config); | |||
|
|
|||
| writer += "@Suppress(\"unused\")"; | |||
| writer += "@ExperimentalUnsignedTypes"; | |||
There was a problem hiding this comment.
do we need to make this optional for kotlin users before 1.5?
There was a problem hiding this comment.
If we change the behaviour to not generate the annotations by default, the user will have to do a change on their build system. Either by invoking flatc with a flag, like --kotlin-unsigned-annotation or by introducing a flags on Kotlin compiler(kotlinc) as defined here.
The other option is to add a flag to suppress generating this annotation --kotlin-supress-unsigned-annotation, keeping the current behaviour default.
AFAIK, Kotlin users adopt newer versions of quite fast so I would be leaning to simply not generating the annotation (keeping current PR as is). Users of old versions can add flags on their build system to remediate that.
Maybe we can leave the PR open for a few more days to see if Kotlin users can provide feedback.
There was a problem hiding this comment.
Thanks for the info. Lets leave open for a bit and if I don't hear anything I will merge.
Remove @ExperimentalUnsignedTypes from generated kotlin code as unsigned types are no longer experimental in Kotlin 1.5 and newer: https://kotlinlang.org/docs/whatsnew15.html#stable-unsigned-integer-types
Fixes #7087