Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderdiff: add initial code for updating goldens #8349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

renderdiff: add initial code for updating goldens #8349

wants to merge 1 commit into from

Conversation

poweifeng
Copy link
Contributor

  • Code for parsing tag in commit message
  • Add placeholder for pulling and updating goldens in the script.

@poweifeng poweifeng added the internal Issue/PR does not affect clients label Jan 14, 2025
@poweifeng poweifeng force-pushed the pf/renderdiff-update-golden branch from 277266d to b0c30a4 Compare January 14, 2025 06:24
@poweifeng
renderdiff: add initial code for updating goldens
c467bab 
 - Code for parsing tag in commit message
 - Add placeholder for pulling and updating goldens in the script.
@poweifeng poweifeng force-pushed the pf/renderdiff-update-golden branch from b0c30a4 to c467bab Compare January 14, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflinger pixelflinger Awaiting requested review from pixelflinger

@z3moon z3moon Awaiting requested review from z3moon

@bejado bejado Awaiting requested review from bejado

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
internal Issue/PR does not affect clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@poweifeng