Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gltfio: [extended] Fix generated color default #7917

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

poweifeng
Copy link
Contributor

Fixes #7905

@poweifeng poweifeng added the internal Issue/PR does not affect clients label Jun 10, 2024
@poweifeng poweifeng merged commit 43331d0 into main Jun 11, 2024
11 checks passed
@poweifeng poweifeng deleted the pf/gltfio-fix-extended-default-color branch June 11, 2024 19:21
@mbalajee
Copy link
Contributor

Doesn't seem to fix the issue. Model (attached in the original issue) still appears all black,
Screenshot 2024-06-11 at 3 31 28 PM
@poweifeng @pixelflinger

@poweifeng
Copy link
Contributor Author

Doesn't seem to fix the issue. Model (attached in the original issue) still appears all black, Screenshot 2024-06-11 at 3 31 28 PM @poweifeng @pixelflinger

Can you attach the model again? It seems corrupted in the previous comment.

@mbalajee
Copy link
Contributor

It was attached as .zip cz of github attachment restriction. Removing the .zip extension should work, i just tried from previous comment.

Here is the same model,
walls.glb.zip

@poweifeng
Copy link
Contributor Author

Let's continue the conversation in #7905.

@mbalajee
Copy link
Contributor

Clean build worked. Model appears as expected. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix for normal generation does not work for UBERSHADER in gltf_viewer app
3 participants