Small compilation fixes #7363
Merged
Small compilation fixes #7363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
poweifeng
commented
Nov 14, 2023
poweifeng
commented
- gltfio: Enable -Wall -Werror for gltfio_core
- gltfio: Fix various errors that were missed warnings
- matdbg: switch from std::atomic_uint64_t to std::atomic<uint64_t> for older clang
poweifeng
requested review from
bejado,
pixelflinger,
z3moon and
romainguy
and removed request for
bejado and
pixelflinger
- gltfio: Enable -Wall -Werror for gltfio_core - gltfio: Fix various errors that were missed warnings - matdbg: switch from std::atomic_uint64_t to std::atomic<uint64_t> for older clang
poweifeng
force-pushed
the
pf/few-random-fixes
branch
from
6eeb062 to
a37980b
Compare
bejado
approved these changes
Nov 14, 2023
poweifeng
added a commit
that referenced
this pull request
Nov 15, 2023
- gltfio: Enable -Wall -Werror for gltfio_core - gltfio: Fix various errors that were missed warnings - matdbg: switch from std::atomic_uint64_t to std::atomic<uint64_t> for older clang
plepers
pushed a commit
to plepers/filament
that referenced
this pull request
Dec 9, 2023
- gltfio: Enable -Wall -Werror for gltfio_core - gltfio: Fix various errors that were missed warnings - matdbg: switch from std::atomic_uint64_t to std::atomic<uint64_t> for older clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.