Cleanup RenderPassNode::declareRenderTarget #7332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z3moon
requested review from
pixelflinger,
elizagamedev,
bejado and
poweifeng
poweifeng
reviewed
Nov 2, 2023
pixelflinger
previously requested changes
Nov 3, 2023
There's no functional change. Remove an unused local variable `outgoingEdges` to save CPU resource. Tidy up an usage of local variable to slightly improve readability.
z3moon
force-pushed
the
zm/refine-declare-render-target
branch
from
d8502d2 to
4c4b3c1
Compare
poweifeng
approved these changes
Nov 6, 2023
plepers
pushed a commit
to plepers/filament
that referenced
this pull request
Dec 9, 2023
There's no functional change. Remove an unused local variable `outgoingEdges` to save CPU resource. Tidy up an usage of local variable to slightly improve readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no functional change. Remove an unused local variable
outgoingEdgesto save CPU resource. Tidy up an usage of local variable to slightly improve readability.