Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup and better bone weight checks #7307

Merged
merged 1 commit into from
Oct 27, 2023
Merged

cleanup and better bone weight checks #7307

merged 1 commit into from
Oct 27, 2023

Conversation

pixelflinger
Copy link
Collaborator

@pixelflinger pixelflinger commented Oct 26, 2023

  • only check/log in debug builds
  • use epsilon = 2e-7 * double(tempPairCount)
  • compute boneWeightsSum in double

FIXES=[306565054]

@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Oct 26, 2023
@google google deleted a comment from github-actions bot Oct 26, 2023
- only check/log in debug builds
- use epsilon = 2e-7 * double(tempPairCount)
- compute boneWeightsSum in double
- don't modify the weights if they're within the threshold

FIXES=[306565054]
@pixelflinger pixelflinger merged commit 2b86c8d into main Oct 27, 2023
8 checks passed
@pixelflinger pixelflinger deleted the ma/boneweights branch October 27, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants