Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk: support stencil format in swapchain #7277

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

poweifeng
Copy link
Contributor

Fixes #7233
FIXES=302197523

@poweifeng poweifeng added the internal Issue/PR does not affect clients label Oct 18, 2023
Copy link
Collaborator

@pixelflinger pixelflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except maybe the use of FixedCapacityVector vs std::array?

@poweifeng poweifeng force-pushed the pf/vk-support-stencil branch from 2347ab4 to 7c4b225 Compare October 19, 2023 17:43
@poweifeng poweifeng merged commit b62991d into main Oct 19, 2023
11 checks passed
@poweifeng poweifeng deleted the pf/vk-support-stencil branch October 19, 2023 20:43
plepers pushed a commit to plepers/filament that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan: Implement stencil buffer support for the default render target
2 participants