Create use-after-free detector for Metal textures #7250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflinger
requested changes
Oct 10, 2023
bejado
force-pushed
the
bjd/use-after-free
branch
from
5a7dfac to
943655f
Compare
pixelflinger
requested changes
Oct 16, 2023
| metalTexture->terminate(); | ||
|
|
||
| // Delay the destruction of this texture handle. | ||
| if (mContext->texturesToDestroy.full()) { |
There was a problem hiding this comment.
Suggested change
| if (mContext->texturesToDestroy.full()) { | |
| if (UTILS_LIKELY(mContext->texturesToDestroy.full())) { |
pixelflinger
approved these changes
Oct 19, 2023
| metalTexture->terminate(); | ||
|
|
||
| if (auto handleToFree = mContext->texturesToDestroy.push(th)) { | ||
| // Delay the destruction of this texture handle. |
There was a problem hiding this comment.
this comment confuses me a little shouldn't it be "delayed destruction of a previously destroyed handle" or something to that effect?
| @@ -854,22 +870,26 @@ | |||
| assert_invariant(sb->size == data.size / sizeof(SamplerDescriptor)); | |||
| auto const* const samplers = (SamplerDescriptor const*) data.buffer; | |||
|
|
|||
| #ifndef NDEBUG | |||
| // In debug builds, verify that all the textures in the sampler group are still alive. | |||
| // Verify that all the textures in the sampler group are still alive. | |||
There was a problem hiding this comment.
unfortunate that this whole loop is technically not needed.
poweifeng
reviewed
Oct 19, 2023
bejado
added a commit
that referenced
this pull request
Oct 20, 2023
plepers
pushed a commit
to plepers/filament
that referenced
this pull request
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.