Add new shading model to Filament for specularGlossiness. #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a shading model based on KHR_materials_pbrSpecularGlossiness. The corollary gltfio change will be in an upcoming PR.
romainguy
reviewed
Apr 9, 2019
docs/Materials.md.html
Outdated
| - Subsurface | ||
| - Cloth | ||
| - Unlit | ||
| - `lit` (or standard) |
There was a problem hiding this comment.
Instead of changing the shading model names to the programmatic versions here, you should update the ### shadingModel section to add specularGlossiness to the list.
docs/Materials.md.html
Outdated
| This alternative lighting model exists to comply with legacy standards. | ||
|
|
||
| Similar to cloth, it encompasses all the parameters previously defined for the standard | ||
| lit mode except for _metallic_ and _reflectance_, and adds a _sheenColor_ parameter. |
There was a problem hiding this comment.
Can you update the ### Material fragment inputs section too? sheenColor is listed as cloth only. Also add a table to describe the parameter, like this:
Parameter | Definition
---------------------:|:---------------------
**sheenColor** | Specular tint to create two-tone specular fabrics (defaults to $\sqrt{baseColor}$)
Property | Type | Range | Note
---------------------:|:--------:|:------------------------:|:-------------------------
**sheenColor** | float3 | [0..1] | Linear RGB
Except in a way that makes sense :)
bejado
approved these changes
Apr 9, 2019
Zefz
pushed a commit
to staaker/filament
that referenced
this pull request
Apr 12, 2019
* Add new shading model to Filament for specularGlossiness. This adds a shading model based on KHR_materials_pbrSpecularGlossiness. The corollary gltfio change will be in an upcoming PR. * Improve documentation for specular-glossiness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a shading model based on KHR_materials_pbrSpecularGlossiness.
The corollary gltfio change will be in an upcoming PR.