Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

System admin user details #995

Merged
merged 8 commits into from
Nov 6, 2020
Merged

System admin user details #995

merged 8 commits into from
Nov 6, 2020

Conversation

whaught
Copy link
Contributor

@whaught whaught commented Nov 6, 2020 •
edited
Loading

Issue #975

Proposed Changes

  • Show user details from the system-admin view
    * Hybrid of the realm user details page and the my-account page
    * Card for basic info
    * Card to show realm membership / admin

details

There is more work to do here

  1. Let system admin jump to realm-admin view (with stats)
  2. Deduplicate a little bit
  3. Remove-user-from-realm link

Release Note

System admin user-details page

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Nov 6, 2020
jeremyfaller
jeremyfaller approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@jeremyfaller jeremyfaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
hold only if you want to address some of these comment

cmd/server/assets/admin/users/show.html Show resolved Hide resolved
cmd/server/assets/admin/users/show.html Outdated Show resolved Hide resolved
cmd/server/assets/admin/users/show.html
<span class="badge badge-primary">Admin</span>
{{end}}
{{end}}
</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you'll end up doing this, but do you want to link to things like disabling the user? Adding them additional realms, etc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is all coming soon, but I want to start a new PR for it. The trouble is that the regular link assumes currentUser and passes a realm - we need to pass both a user and a realm for the system-admin case

@whaught
Copy link
Contributor Author

whaught commented Nov 6, 2020

/unhold

sethvargo
sethvargo approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyfaller, sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jeremyfaller,sethvargo,whaught]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 9e8cabc into google:main Nov 6, 2020
@whaught whaught deleted the user-details branch November 6, 2020 21:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@jeremyfaller jeremyfaller jeremyfaller approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

Assignees

@sethvargo sethvargo

@jeremyfaller jeremyfaller

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@whaught @google-oss-robot @sethvargo @jeremyfaller @googlebot