Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Rename Admin to SystemAdmin in users table #984

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

sethvargo
Copy link
Member

Just a simple rename, but now that we're merging some functionality, I want to be clear when we say "system admin". This has also confused our partners in the past.

Release Note

Rename users `admin` to `system_admin` for clarity.

/assign @whaught

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Nov 5, 2020
sqls := []string{
`
DO $$
BEGIN
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoMigrate striking again 😦

Copy link
Contributor

@whaught whaught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this - it always felt ambiguous with system/realm admin

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit f76a3ce into main Nov 5, 2020
@google-oss-robot google-oss-robot deleted the sethvargo/system_admin branch November 5, 2020 19:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants