-
Notifications
You must be signed in to change notification settings - Fork 83
Optionally mirror dependent Docker Hub images #981
Conversation
Also allow customizing the image used in CI via an environment variable.
@chaodaiG to use this, we'll need to:
Any thoughts on which project we should use? I already ran the Terraform against one for testing, so we could use that one. It doesn't have to be the same project as Prow. |
The GCP projects used for testing are not relevant in presubmit tests right now, the only cluster used for presubmit tests is the prow build cluster. So I would prefer let prow build cluster host these images.
The prow service account used for test is the default compute engine service account for the project, I can grant it permission |
That would involve a decent amount of setup on the prow projects.
See the PR in the -infra repo (I CCed you). |
I see your point, and agreed. we can use one of the test project for this, let's use |
@chaodaiG do we run the risk of that project being auto-deleted or cleaned up? I'd rather use one of our more static projects. |
@sethvargo , actually you're right, there is a risk of cloud run service being cleaned up, but it's controlled by us. I wouldn't imagine the images being cleaned up though. For static project, we don't have a different static project yet other than the prow build cluster, if desired we can set up another one, but it'll take some time for a reason. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also allow customizing the image used in CI via an environment variable.
Fixes #959
Release Note
/assign @chaodaiG