-
Notifications
You must be signed in to change notification settings - Fork 83
Conversation
pkg/controller/verifyapi/verify.go
Outdated
@@ -41,6 +42,7 @@ import ( | |||
func (c *Controller) HandleVerify() http.Handler { | |||
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | |||
ctx := observability.WithBuildInfo(r.Context()) | |||
ctx = logging.WithLogger(ctx, c.logger.Named("handleverify")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm - this should be:
logger := c.logger.Named("HandleVerify")
and then update to use logger
instead of c.logger
in the rest of the method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed - changed direction, don't need this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikehelmick, sethvargo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Fixes #946
Proposed Changes
Release Note