Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Add alerting playbooks #911

Merged
merged 8 commits into from
Oct 29, 2020
Merged

Add alerting playbooks #911

merged 8 commits into from
Oct 29, 2020

Conversation

icco
Copy link
Contributor

@icco icco commented Oct 27, 2020 •
edited
Loading

For #824

Proposed Changes

  • Adds alert playbooks, cowritten with @mariliamelo
  • TODO is add links to alerts, and write one more playbook

Release Note

Adds alert playbooks

@google-oss-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@googlebot googlebot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Oct 27, 2020
@icco icco changed the title Alertingdocs Add alerting playbooks Oct 28, 2020
@icco icco marked this pull request as ready for review October 28, 2020 18:00
@icco
Copy link
Contributor Author

icco commented Oct 28, 2020

/assign @yuriatgoogle

@icco
Copy link
Contributor Author

icco commented Oct 29, 2020

/assign @mariliamelo

mariliamelo
mariliamelo approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@mariliamelo mariliamelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, mariliamelo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuriatgoogle
Copy link
Contributor

/lgtm

@google-oss-robot google-oss-robot merged commit cedd654 into google:main Oct 29, 2020
@icco icco deleted the alertingdocs branch October 29, 2020 17:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mariliamelo mariliamelo mariliamelo approved these changes

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

Assignees

@mariliamelo mariliamelo

@yuriatgoogle yuriatgoogle

Labels
cla: yes Auto: added by CLA bot when all committers have signed a CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@icco @google-oss-robot @yuriatgoogle @mariliamelo @googlebot